FS-3106 --comment-only Try this out, its got a few elements from your patch but…

FS-3106 --comment-only Try this out, its got a few elements from your patch but there was a much bigger problem deeper in the code preventing the sqlite handles from being recycled properly

src/include/switch_core.h

@@ -2075,52 +2075,53 @@ SWITCH_DECLARE(switch_status_t) switch_ivr_preprocess_session(switch_core_sessio
 */
 
 #define CACHE_DB_LEN 256
-	 typedef enum {
-		 CDF_INUSE = (1 << 0),
-		 CDF_PRUNE = (1 << 1)
-	 } cache_db_flag_t;
-
-	 typedef enum {
-		 SCDB_TYPE_CORE_DB,
-		 SCDB_TYPE_ODBC
-	 } switch_cache_db_handle_type_t;
-
-	 typedef union {
-		 switch_core_db_t *core_db_dbh;
-		 switch_odbc_handle_t *odbc_dbh;
-	 } switch_cache_db_native_handle_t;
-
-	 typedef struct {
-		 char *db_path;
-	 } switch_cache_db_core_db_options_t;
-
-	 typedef struct {
-		 char *dsn;
-		 char *user;
-		 char *pass;
-	 } switch_cache_db_odbc_options_t;
-
-	 typedef union {
-		 switch_cache_db_core_db_options_t core_db_options;
-		 switch_cache_db_odbc_options_t odbc_options;
-	 } switch_cache_db_connection_options_t;
-
-	 typedef struct {
-		 char name[CACHE_DB_LEN];
-		 switch_cache_db_handle_type_t type;
-		 switch_cache_db_native_handle_t native_handle;
-		 time_t last_used;
-		 switch_mutex_t *mutex;
-		 switch_mutex_t *io_mutex;
-		 switch_memory_pool_t *pool;
-		 int32_t flags;
-		 unsigned long hash;
-		 char creator[CACHE_DB_LEN];
-		 char last_user[CACHE_DB_LEN];
-	 } switch_cache_db_handle_t;
-
-
-	 static inline const char *switch_cache_db_type_name(switch_cache_db_handle_type_t type)
+typedef enum {
+	CDF_INUSE = (1 << 0),
+	CDF_PRUNE = (1 << 1),
+	CDF_RELEASED = (1 << 2)
+} cache_db_flag_t;
+
+typedef enum {
+	SCDB_TYPE_CORE_DB,
+	SCDB_TYPE_ODBC
+} switch_cache_db_handle_type_t;
+
+typedef union {
+	switch_core_db_t *core_db_dbh;
+	switch_odbc_handle_t *odbc_dbh;
+} switch_cache_db_native_handle_t;
+
+typedef struct {
+	char *db_path;
+} switch_cache_db_core_db_options_t;
+
+typedef struct {
+	char *dsn;
+	char *user;
+	char *pass;
+} switch_cache_db_odbc_options_t;
+
+typedef union {
+	switch_cache_db_core_db_options_t core_db_options;
+	switch_cache_db_odbc_options_t odbc_options;
+} switch_cache_db_connection_options_t;
+
+typedef struct {
+	char name[CACHE_DB_LEN];
+	switch_cache_db_handle_type_t type;
+	switch_cache_db_native_handle_t native_handle;
+	time_t last_used;
+	switch_mutex_t *mutex;
+	switch_mutex_t *io_mutex;
+	switch_memory_pool_t *pool;
+	int32_t flags;
+	unsigned long hash;
+	char creator[CACHE_DB_LEN];
+	char last_user[CACHE_DB_LEN];
+} switch_cache_db_handle_t;
+
+
+static inline const char *switch_cache_db_type_name(switch_cache_db_handle_type_t type)
 {
 	const char *type_str = "INVALID";
 

src/switch_core_db.c

@@ -94,7 +94,7 @@ SWITCH_DECLARE(int) switch_core_db_exec(switch_core_db_t *db, const char *sql, s
 		if (ret == SQLITE_BUSY || ret == SQLITE_LOCKED) {
 			if (sane > 1) {
 				switch_core_db_free(err);
-				switch_yield(100000);
+				switch_yield(1000); /* Was 100000. I think it's too much */
 				continue;
 			}
 		} else {
@@ -182,9 +182,27 @@ SWITCH_DECLARE(switch_core_db_t *) switch_core_db_open_file(const char *filename
 {
 	switch_core_db_t *db;
 	char path[1024];
+	int db_ret;
 
 	db_pick_path(filename, path, sizeof(path));
-	if (switch_core_db_open(path, &db)) {
+	if ((db_ret = switch_core_db_open(path, &db)) != SQLITE_OK) {
+		goto end;
+	}
+	if ((db_ret = switch_core_db_exec(db, "PRAGMA synchronous=OFF;", NULL, NULL, NULL) != SQLITE_OK)) {
+		goto end;
+	}
+	if ((db_ret = switch_core_db_exec(db, "PRAGMA count_changes=OFF;", NULL, NULL, NULL) != SQLITE_OK)) {
+		goto end;
+	}
+	if ((db_ret = switch_core_db_exec(db, "PRAGMA cache_size=8000;", NULL, NULL, NULL) != SQLITE_OK)) {
+		goto end;
+	}
+	if ((db_ret = switch_core_db_exec(db, "PRAGMA temp_store=MEMORY;", NULL, NULL, NULL) != SQLITE_OK)) {
+		goto end;
+	}
+
+end:
+	if (db_ret != SQLITE_OK) {
 		switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, "SQL ERR [%s]\n", switch_core_db_errmsg(db));
 		switch_core_db_close(db);
 		db = NULL;