FS-3676 --resolve mod_lcr - convert assert to log and fix check condition

src/mod/applications/mod_lcr/mod_lcr.c

@@ -626,6 +626,8 @@ static int route_add_callback(void *pArg, int argc, char **argv, char **columnNa
 			if (!argv[i] || zstr(argv[i])) {
 				/* maybe we want to consider saying which carriers have null rate fields... maybe they can run the query and find out */
 				switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_INFO, "rate field is null, skipping\n");
+				/* kill prev/next pointers */
+				/* additional->prev = NULL; */
 				goto end;
 			}
 			additional->rate = (float)atof(switch_str_nil(argv[i]));
@@ -750,8 +752,16 @@ static int route_add_callback(void *pArg, int argc, char **argv, char **columnNa
 
 	/* lcr was not added to any lists, so destroy lcr object here */
 	if (lcr_skipped == SWITCH_TRUE) {
-		/* ensure we didn't accidentally add additional to the list */
-		switch_assert(additional->prev == NULL && current->next != additional);
+		/* complain loudly if we're asked to destroy a route that is
+		   added to the route list */
+		if (additional && additional->prev != NULL) {
+			switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, 
+			                  "additional->prev != NULL\n");
+		}
+		if (current && current->next == additional) {
+			switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_ERROR, 
+			                  "current->next == additional\n");
+		}
 		lcr_destroy(additional);
 	}