fix mod_basic clang build warning, we don't need to declare var we don't use on this side of the ifdef

This commit also reverts 2 previous attempts to fix this very rare race issue spanning back to 2009

62ce8538 Patch from MOC
3a85348c FS-2302 mutex added around switch_xml_toxml()

The real problem was switch_xml_toxml_buf() was actually temporarily modifying the xml structure being searialized to make it appaer to be a root structure then serializing it and restoring the pointers.  This caused a non-threadsafe operation when some other thread was scanning the same xml structure.

This patch removes the modification and instead passes a new arg to switch_xml_toxml_r indicating to treat the structure as if it were a root structure.

This bug has been present since the induction of xml into FS.

We already had uuid_answer and uuid_pre_answer, so we might as well
add uuid_ring_ready.

Since libedit originates from NetBSD, this and other BSDs use the
official version while Linux distributions tend to use the
autotoolized fork. The official version does not install a .pc file so
we cannot rely exclusively on pkg-config for detection.

FS-6408
Signed-off-by: Travis Cross <tc@traviscross.com>

Don't use CFLAGS or CXXFLAGS for this because AC_CHECK_HEADER only
uses CPPFLAGS.

FS-6408
Signed-off-by: Travis Cross <tc@traviscross.com>

FS-6413 --resolve with this patch you will need to make sure the boxes have the clocks synced and both started inside the same occurence of the most recent new year.

also push PKG_CONFIG_SYSROOT_DIR and set some test results that can not be figured out during cross compile explicitly for arm-linux-gnueabi*|arm-*-linux-gnueabi*

push sysroot down to other libs and things that don't use libtool as well, so you don't need to specify it in a bunch of different ways when using it.

FS-6410 Adding some log lines to mod_sonar so that it is more clear what is happening when the app is sending and detecting pings.

make cross compile a bit easier, as this setitng needs to be set manually, and we never use this feature