1. 22 8月, 2014 11 次提交
    • William King's avatar
    • Travis Cross's avatar
      Help the static analyzer in `handle_ice` · aa1a05d0
      Travis Cross 提交于
      Clang's static analyzer thinks we could be using `hosts` here when it
      is NULL.  We probably weren't, but it's easy to see how it could think
      so.  We were checking whether `from_addr` matched `ice->addr` three
      times, and between the second on third time we might have modified the
      `ice->addr`; however we only get there if it matched the second time,
      so we could only make it not match at that point and avoid the third
      branch.  We can't make it match where it did not before.
      
      We'll simplify the logic a bit here so static analyzers (and humans)
      can hopefully see this more readily.
      aa1a05d0
    • Travis Cross's avatar
      Return NULL from `sub_alloc` for zero size · 3c32dd3b
      Travis Cross 提交于
      When zero was passed for the size to `sub_alloc`, we were passing this
      size on to `malloc` or `calloc`, which is unusual enough that static
      analyzers warn about this (POSIX says that either NULL or a pointer
      will be returned).
      
      We'll instead just return NULL right away.
      3c32dd3b
    • Travis Cross's avatar
      Fix spelling "Couldnt" -> "Couldn't" · 959e672a
      Travis Cross 提交于
      959e672a
    • Travis Cross's avatar
      Handle zero channels when allocating for resampler · decc19cc
      Travis Cross 提交于
      When the number of channels was zero, we were calling malloc with a
      size of zero.  While defined, this is unusual.  And since we're
      initializing the speex resampler as though there were one channel in
      this case, we should probably just allocate the space for it.
      decc19cc
    • Travis Cross's avatar
      Refactor to avoid warning about realloc usage · 164fa133
      Travis Cross 提交于
      Clang's static analyzer noticed the result of realloc was being
      assigned to a pointer of a different type than was used to calculate
      the new size.  We can make things simpler and more idiomatic here by
      using the correct pointer type and letting C's pointer arithmetic
      automatically handle some multiplication.
      
      We also use the distributive property here to simplify the calculation
      for memset.
      164fa133
    • Travis Cross's avatar
      Remove dead assignments in `switch.c` · 2cf6fd72
      Travis Cross 提交于
      2cf6fd72
    • Travis Cross's avatar
      Handle null argv in `switch.c` · 4f81e594
      Travis Cross 提交于
      4f81e594
    • Travis Cross's avatar
      Remove dead assignment · e2d67d4e
      Travis Cross 提交于
      e2d67d4e
    • Travis Cross's avatar
      Avoid using undefined memory in `switch_fulldate_cmp` · b5a87aea
      Travis Cross 提交于
      The `switch_split_date` and `switch_split_time` functions only set as
      many variables as they believe exist values in the input string.
      Since we didn't have defaults assigned we would read undefined stack
      memory if the input string didn't contain e.g. an hour.
      
      With this commit, we use 1970 if no year is present, January if no
      month is present, the first day of the month if none is given, and
      zero for each of a missing hour, minute, or second.
      b5a87aea
    • Travis Cross's avatar
      Refactor `switch_fulldate_cmp` · bf42dd65
      Travis Cross 提交于
      We're moving the variable declarations down to the smallest possible
      scope (a good idea in general) so we can address the use of undefined
      memory by the function in a later commit.
      bf42dd65
  2. 21 8月, 2014 5 次提交
  3. 20 8月, 2014 3 次提交
  4. 19 8月, 2014 2 次提交
  5. 18 8月, 2014 4 次提交
  6. 17 8月, 2014 1 次提交
  7. 16 8月, 2014 2 次提交
  8. 15 8月, 2014 6 次提交
  9. 14 8月, 2014 3 次提交
  10. 13 8月, 2014 3 次提交
    • Travis Cross's avatar
      Cleanup whitespace · 8d84aa25
      Travis Cross 提交于
      8d84aa25
    • Peter Wu's avatar
      libzrtp: update zrtp_sleep for modern libc · 21c145b1
      Peter Wu 提交于
      usleep is deprecated and disabled in glibc 2.12 unless requested. Use
      nanosleep instead if available.
      
      This fixes the following compiler warning:
      
          ./src/zrtp_iface_scheduler.c: In function 'zrtp_sleep':
          ./src/zrtp_iface_scheduler.c:96:2: warning: implicit declaration of
          function 'usleep' [-Wimplicit-function-declaration]
            usleep(msec*1000);
            ^
      21c145b1
    • Peter Wu's avatar
      libsrtp: do not include unnecessary sources · 98502947
      Peter Wu 提交于
      These two files should only be built when OpenSSL is not enabled. See
      the configure script of the original sources and Makefile from upstream.
      (RNG_EXTRA_OBJS)
      
      Fixes a -Wimplicit-function-declaration warning.
      98502947